FIX knobs select to actually support rich values #4522
Merged
+35
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
Hypnosphi,
alexandrebodin,
alterx,
danielduan,
leonrodenburg,
theinterned and
usulpro
as code owners
|
@sapkra This should truly fix the issue. The problem was indeed that trying to set a rich value as a value on So In this PR I'm mapping back to the object-key (which should always be a string). Also simplified the code a bit. |
|
If you'd like to review the code perhaps? |
Codecov Report
@@ Coverage Diff @@
## master #4522 +/- ##
======================================
Coverage 35.7% 35.7%
======================================
Files 557 557
Lines 6708 6708
Branches 879 879
======================================
Hits 2395 2395
Misses 3858 3858
Partials 455 455
Continue to review full report at Codecov.
|
Hypnosphi
reviewed
Oct 25, 2018
| const SelectType = ({ knob, onChange }) => { | ||
| const { options } = knob; | ||
| const entries = Array.isArray(options) | ||
| ? options.reduce((acc, k) => Object.assign(acc, { k }), {}) |
There was a problem hiding this comment.
it should be {[k]: k} instead of {k}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4402