You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at the existing implementation of delayWhen I found another problem. See #3665 if you are interested in fixing it whilst you are working with that particular operator's implementation. The fix should go into its own PR, of course.
Yeah, I thought about this when first looking at it as well and then just forgot about it. I think my first PR attempt is no good. We'll need a better solution.
Activity
Airblader commentedon May 7, 2018
does work as intended, so this seems to be an issue with the synchronicity.
fix(delayWhen): Emit source value if duration selector completes sync…
cartant commentedon May 7, 2018
Looking at the existing implementation of
delayWhen
I found another problem. See #3665 if you are interested in fixing it whilst you are working with that particular operator's implementation. The fix should go into its own PR, of course.Airblader commentedon May 7, 2018
Yeah, I thought about this when first looking at it as well and then just forgot about it. I think my first PR attempt is no good. We'll need a better solution.
Airblader commentedon May 7, 2018
OK,
subscribeToResult
memorizes the outerValue, so I think we can use that and be good. Updating the PR.fix(delayWhen): Emit source value if duration selector completes sync…
fix(delayWhen): Emit source value if duration selector completes sync…
benlesh commentedon May 9, 2018
The OP here isn't valid.
of(42).pipe(() => empty())
should returnempty
, effectively... so there would be no emission.Airblader commentedon May 9, 2018
@benlesh Sorry, I messed up my OP when editing it. It's missing the delayWhen.
The correct example was
fix(delayWhen): Emit source value if duration selector completes sync…
fix(delayWhen): Emit source value if duration selector completes sync…