-
Notifications
You must be signed in to change notification settings - Fork 238
Upgrade TypeScript dependency to 2.7.2 #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
How is the dev dependency preventing you from using the tool? |
At Google, its a standard practice to import TS sources for NPM modules. But we can only have one copy of TypeScript NPM module. When I tried to build codelyzer from its sources, these are the errors I got (because codelyzer is depending on old TS version):
|
I would be happy to upgrade codelyzer to TS 2.7.2, but I might have noob questions. For example: how do I run codelyzer tests? |
I'll take a look at this today. |
Sounds good. Thanks Minko! Let me know if i can help. |
@mertdeg2 would you try the branch |
Cool! Now I am getting only one failure:
|
@mertdeg2 I added the return type to |
Nope, this works. Thanks! :) |
https://github.com/mgechev/codelyzer/blob/4.3.0/package.json#L69
We couldn't use codelyzer because its pinning TS 2.4
The text was updated successfully, but these errors were encountered: