Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Conversation

ouadie-lahdioui
Copy link
Collaborator

@ouadie-lahdioui ouadie-lahdioui commented Jan 24, 2018

Hello,

While error in getting tags list, Botkit doesn't call cb function with the error. this PR allows tags.get_all to handle the cb function with err parameter, it also check if cb exists before calling it.

Enjoy,

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@benbrown
Copy link
Contributor

this will be included in 0.6.9

@benbrown benbrown merged commit d807340 into howdyai:master Jan 29, 2018
@ouadie-lahdioui ouadie-lahdioui deleted the faceBook/CallCBWithError branch January 29, 2018 21:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

3 participants