refactor(transaction): error handling #360
Merged
+89
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmehiphop
added
the
do not merge
googlebot
added
the
cla: yes
ghost
assigned
|
/cc @eric4545 |
eric4545
approved these changes
Oct 4, 2018
src/transaction.js
Outdated
| this.request( | ||
| { | ||
| client: 'SpannerClient', | ||
| method: 'commit', | ||
| reqOpts: reqOpts, | ||
| }, | ||
| function(err, resp) { | ||
| (err, resp) => { | ||
| if (!err) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@callmehiphop @crwilcox just checking in on where this one is :) |
callmehiphop
removed
the
do not merge
stephenplusplus
approved these changes
Nov 15, 2018
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325