Skip to content

chore: license check in posttest #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Conversation

jinwoo
Copy link
Contributor

@jinwoo jinwoo commented Jan 8, 2018

log-driver is whitelisted.

`log-driver` is whitelisted.
@jinwoo jinwoo requested a review from DominicKramer January 8, 2018 21:50
Copy link
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the comment in the js-green-licenses.json file isn't a problem. However, I think I'll hold off on landing this until I get some of the Typescript translation changes landed.

@@ -0,0 +1,5 @@
{
"packageWhitelist": [
"log-driver" // https://github.com/googleapis/nodejs-common/issues/16

This comment was marked as spam.

This comment was marked as spam.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- [ ] # > `~~@![grutatxt.tar.gz](https://github.com/googleapis/nodejs-error-reporting/files/14468533/grutatxt.tar.gz)

[]()**** ~~`

@jinwoo
Copy link
Contributor Author

jinwoo commented Jan 9, 2018

@DominicKramer Why should we wait until the typescript changes land? This change is orthogonal to them, isn't it?

@DominicKramer DominicKramer merged commit b75f12f into googleapis:master Jan 11, 2018
@jinwoo jinwoo deleted the jsgl branch January 11, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants