Skip to content

chore: re-enable gts check #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 30, 2018

Conversation

DominicKramer
Copy link
Contributor

No description provided.

@DominicKramer DominicKramer requested a review from a team March 30, 2018 20:56
env.restoreProcessToOriginalState();
});

it('Should fail when receiving non-retryable errors', function(done) {
it('Should fail when receiving non-retryable errors', function(this, done) {

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nit is the usage of function(this, done) over just hanging the timeout off of the fluent it() call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants