Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/gax-nodejs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.20.0
Choose a base ref
...
head repository: googleapis/gax-nodejs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.21.0
Choose a head ref

Commits on Sep 18, 2018

  1. Copy the full SHA
    8486326 View commit details

Commits on Sep 20, 2018

  1. Copy the full SHA
    09b4eb3 View commit details

Commits on Sep 22, 2018

  1. Update CI config (#306)

    dpebot authored and JustinBeckwith committed Sep 22, 2018
    Copy the full SHA
    3ad7a85 View commit details

Commits on Sep 25, 2018

  1. Copy the full SHA
    d56c80a View commit details
  2. Copy the full SHA
    c24f46e View commit details
  3. Update the kokoro config (#309)

    dpebot authored and JustinBeckwith committed Sep 25, 2018
    Copy the full SHA
    351c29d View commit details

Commits on Sep 27, 2018

  1. Copy the full SHA
    3a8bca1 View commit details

Commits on Sep 28, 2018

  1. Update CI config (#312)

    dpebot authored and JustinBeckwith committed Sep 28, 2018
    Copy the full SHA
    179a351 View commit details
  2. Copy the full SHA
    7d94a8b View commit details

Commits on Oct 2, 2018

  1. Update kokoro config (#315)

    dpebot authored and JustinBeckwith committed Oct 2, 2018
    Copy the full SHA
    67a2f7c View commit details

Commits on Oct 10, 2018

  1. Copy the full SHA
    8b1298f View commit details

Commits on Oct 15, 2018

  1. Copy the full SHA
    f81c2a8 View commit details
  2. Copy the full SHA
    b7f831a View commit details

Commits on Oct 16, 2018

  1. Copy the full SHA
    6652417 View commit details

Commits on Oct 20, 2018

  1. chore: update new issue template (#323)

    chore: update new issue template
    dpebot authored and JustinBeckwith committed Oct 20, 2018
    Copy the full SHA
    be94b30 View commit details

Commits on Oct 22, 2018

  1. Copy the full SHA
    7a8001c View commit details
  2. Copy the full SHA
    9d137f8 View commit details

Commits on Oct 23, 2018

  1. Copy the full SHA
    084239e View commit details

Commits on Oct 24, 2018

  1. build: run tests on node11 (#327)

    * build: run tests on node11
    
    * build: run tests on node11
    
    * build: run tests on node11
    
    * build: run tests on node11
    jkwlui authored and JustinBeckwith committed Oct 24, 2018
    Copy the full SHA
    134f642 View commit details
  2. Copy the full SHA
    d1fd0a3 View commit details
  3. Update issue templates

    JustinBeckwith committed Oct 24, 2018
    Copy the full SHA
    5e691e5 View commit details

Commits on Oct 25, 2018

  1. Copy the full SHA
    40f85b2 View commit details

Commits on Oct 28, 2018

  1. Copy the full SHA
    69e55c7 View commit details

Commits on Oct 30, 2018

  1. Copy the full SHA
    80d39c8 View commit details

Commits on Nov 2, 2018

  1. Copy the full SHA
    f7444da View commit details

Commits on Nov 5, 2018

  1. Copy the full SHA
    8f79896 View commit details

Commits on Nov 7, 2018

  1. Copy the full SHA
    634b2be View commit details
  2. Copy the full SHA
    b63a8aa View commit details

Commits on Nov 8, 2018

  1. Copy the full SHA
    18ad841 View commit details

Commits on Nov 9, 2018

  1. Copy the full SHA
    c315944 View commit details
  2. Copy the full SHA
    0083e85 View commit details
  3. Copy the full SHA
    87ca2ad View commit details

Commits on Nov 10, 2018

  1. Copy the full SHA
    670d549 View commit details

Commits on Nov 12, 2018

  1. Copy the full SHA
    c3aab52 View commit details
Showing with 458 additions and 255 deletions.
  1. +0 −20 .appveyor.yml
  2. +2 −3 .circleci/config.yml
  3. BIN .circleci/key.json.enc
  4. +1 −1 .circleci/npm-install-retry.js
  5. +1 −0 .eslintignore
  6. +2 −0 .eslintrc.yml
  7. +14 −8 .github/{ISSUE_TEMPLATE.md → ISSUE_TEMPLATE/bug_report.md}
  8. +18 −0 .github/ISSUE_TEMPLATE/feature_request.md
  9. +7 −0 .github/ISSUE_TEMPLATE/support_request.md
  10. +1 −0 .gitignore
  11. +24 −0 .kokoro/continuous/node11/common.cfg
  12. 0 .kokoro/continuous/node11/test.cfg
  13. +9 −0 .kokoro/continuous/node8/test.cfg
  14. +24 −0 .kokoro/presubmit/node11/common.cfg
  15. 0 .kokoro/presubmit/node11/test.cfg
  16. +7 −0 .kokoro/presubmit/node8/samples-test.cfg
  17. +7 −0 .kokoro/presubmit/node8/system-test.cfg
  18. +9 −0 .kokoro/presubmit/node8/test.cfg
  19. +0 −7 .kokoro/presubmit/windows/common.cfg
  20. +7 −0 .kokoro/samples-test.sh
  21. +2 −0 .kokoro/system-test.sh
  22. +2 −1 .kokoro/test.bat
  23. +2 −1 .kokoro/test.sh
  24. +42 −0 CHANGELOG.md
  25. +4 −0 codecov.yaml
  26. +25 −17 package.json
  27. +1 −1 samples/package.json
  28. +1 −6 src/api_callable.ts
  29. +0 −1 src/auth.ts
  30. +2 −5 src/bundling.ts
  31. +0 −2 src/gax.ts
  32. +28 −34 src/grpc.ts
  33. +13 −22 src/index.ts
  34. +0 −3 src/longrunning.ts
  35. +11 −13 src/operations_client.ts
  36. +5 −8 src/paged_iteration.ts
  37. +1 −6 src/parser_extras.ts
  38. +2 −3 src/path_template.ts
  39. +7 −11 src/{path_template_parser.ts → path_template_parser.js}
  40. +2 −4 src/path_template_parser.pegjs
  41. +0 −2 src/routing_header.ts
  42. +3 −3 src/streaming.ts
  43. +125 −1 system-test/system.ts
  44. +4 −7 test/api_callable.ts
  45. +0 −1 test/auth.ts
  46. +19 −23 test/bundling.ts
  47. +1 −2 test/gax.ts
  48. +4 −7 test/grpc.ts
  49. +4 −6 test/longrunning.ts
  50. +4 −6 test/paged_iteration.ts
  51. +3 −4 test/path_template.ts
  52. +0 −1 test/path_template_parser.ts
  53. +0 −1 test/routing_header.ts
  54. +3 −6 test/streaming.ts
  55. +2 −4 test/utils.ts
  56. +3 −4 tsconfig.json
20 changes: 0 additions & 20 deletions .appveyor.yml

This file was deleted.

5 changes: 2 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -68,8 +68,6 @@ jobs:
environment:
NPM_CONFIG_PREFIX: /home/node/.npm-global
- run: npm test
- run: node_modules/.bin/codecov

node8:
docker:
- image: 'node:8'
@@ -161,7 +159,8 @@ jobs:
command: npm run system-test
environment:
GCLOUD_PROJECT: long-door-651
GOOGLE_APPLICATION_CREDENTIALS: .circleci/key.json
GOOGLE_APPLICATION_CREDENTIALS: /home/node/project/.circleci/key.json
NPM_CONFIG_PREFIX: /home/node/.npm-global
- run:
name: Remove unencrypted key.
command: |
Binary file added .circleci/key.json.enc
Binary file not shown.
2 changes: 1 addition & 1 deletion .circleci/npm-install-retry.js
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ let spawn = require('child_process').spawn;
//USE: ./index.js <ms npm can be idle> <number of attempts> [... NPM ARGS]
//

let timeout = process.argv[2] || 60000;
let timeout = process.argv[2] || process.env.NPM_INSTALL_TIMEOUT || 60000;
let attempts = process.argv[3] || 3;
let args = process.argv.slice(4);
if (args.length === 0) {
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
node_modules/*
samples/node_modules/*
src/**/doc/*
build/
2 changes: 2 additions & 0 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
@@ -11,3 +11,5 @@ rules:
block-scoped-var: error
eqeqeq: error
no-warning-comments: warn
no-var: error
prefer-const: error
22 changes: 14 additions & 8 deletions .github/ISSUE_TEMPLATE.md → .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
---
name: Bug report
about: Create a report to help us improve

---

Thanks for stopping by to let us know something could be better!

Please run down the following list and make sure you've tried the usual "quick
fixes":
**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response.

Please run down the following list and make sure you've tried the usual "quick fixes":

- Search the issues already opened: https://github.com/googleapis/gax-nodejs/issues
- Search the issues on our "catch-all" repository: https://github.com/GoogleCloudPlatform/google-cloud-node
- Search the issues on our "catch-all" repository: https://github.com/googleapis/google-cloud-node
- Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js

If you are still having issues, please be sure to include as much information as
possible:
If you are still having issues, please be sure to include as much information as possible:

#### Environment details

@@ -19,9 +25,9 @@ possible:

#### Steps to reproduce

1. ???
2. ???
1. ?
2. ?

Following these steps will guarantee the quickest resolution possible.
Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!
18 changes: 18 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
name: Feature request
about: Suggest an idea for this library

---

Thanks for stopping by to let us know something could be better!

**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response.

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
7 changes: 7 additions & 0 deletions .github/ISSUE_TEMPLATE/support_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
name: Support request
about: If you have a support contract with Google, please create an issue in the Google Cloud Support console.

---

**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -11,3 +11,4 @@ system-test/*key.json
build
.vscode
package-lock.json
system-test-run/
24 changes: 24 additions & 0 deletions .kokoro/continuous/node11/common.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Format: //devtools/kokoro/config/proto/build.proto

# Build logs will be here
action {
define_artifacts {
regex: "**/*sponge_log.xml"
}
}

# Download trampoline resources.
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline"

# Use the trampoline script to run in docker.
build_file: "gax-nodejs/.kokoro/trampoline.sh"

# Configure the docker image for kokoro-trampoline.
env_vars: {
key: "TRAMPOLINE_IMAGE"
value: "gcr.io/cloud-devrel-kokoro-resources/node:11-user"
}
env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/gax-nodejs/.kokoro/test.sh"
}
Empty file.
9 changes: 9 additions & 0 deletions .kokoro/continuous/node8/test.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Bring in codecov.io master token into the build as $KOKORO_KEYSTORE_DIR/73713_dpebot_codecov_token
before_action {
fetch_keystore {
keystore_resource {
keystore_config_id: 73713
keyname: "dpebot_codecov_token"
}
}
}
24 changes: 24 additions & 0 deletions .kokoro/presubmit/node11/common.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Format: //devtools/kokoro/config/proto/build.proto

# Build logs will be here
action {
define_artifacts {
regex: "**/*sponge_log.xml"
}
}

# Download trampoline resources.
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline"

# Use the trampoline script to run in docker.
build_file: "gax-nodejs/.kokoro/trampoline.sh"

# Configure the docker image for kokoro-trampoline.
env_vars: {
key: "TRAMPOLINE_IMAGE"
value: "gcr.io/cloud-devrel-kokoro-resources/node:11-user"
}
env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/gax-nodejs/.kokoro/test.sh"
}
Empty file.
7 changes: 7 additions & 0 deletions .kokoro/presubmit/node8/samples-test.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Download resources for system tests (service account key, etc.)
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs"

env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/gax-nodejs/.kokoro/samples-test.sh"
}
7 changes: 7 additions & 0 deletions .kokoro/presubmit/node8/system-test.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Download resources for system tests (service account key, etc.)
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs"

env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/gax-nodejs/.kokoro/system-test.sh"
}
9 changes: 9 additions & 0 deletions .kokoro/presubmit/node8/test.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Bring in codecov.io master token into the build as $KOKORO_KEYSTORE_DIR/73713_dpebot_codecov_token
before_action {
fetch_keystore {
keystore_resource {
keystore_config_id: 73713
keyname: "dpebot_codecov_token"
}
}
}
7 changes: 0 additions & 7 deletions .kokoro/presubmit/windows/common.cfg
Original file line number Diff line number Diff line change
@@ -1,9 +1,2 @@
# Format: //devtools/kokoro/config/proto/build.proto

# Build logs will be here
action {
define_artifacts {
regex: "**/*sponge_log.xml"
}
}

7 changes: 7 additions & 0 deletions .kokoro/samples-test.sh
Original file line number Diff line number Diff line change
@@ -24,6 +24,13 @@ export GCLOUD_PROJECT=long-door-651

cd $(dirname $0)/..

# Run a pre-test hook, if a pre-samples-test.sh is in the project
if [ -f .kokoro/pre-samples-test.sh ]; then
set +x
. .kokoro/pre-samples-test.sh
set -x
fi

npm install

# Install and link samples
2 changes: 2 additions & 0 deletions .kokoro/system-test.sh
Original file line number Diff line number Diff line change
@@ -26,7 +26,9 @@ cd $(dirname $0)/..

# Run a pre-test hook, if a pre-system-test.sh is in the project
if [ -f .kokoro/pre-system-test.sh ]; then
set +x
. .kokoro/pre-system-test.sh
set -x
fi

npm install
3 changes: 2 additions & 1 deletion .kokoro/test.bat
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@rem Copyright 2018 gRPC authors.
@rem Copyright 2018 Google LLC. All rights reserved.
@rem
@rem Licensed under the Apache License, Version 2.0 (the "License");
@rem you may not use this file except in compliance with the License.
@@ -17,6 +17,7 @@
cd /d %~dp0
cd ..

call npm install -g npm@latest || goto :error
call npm install || goto :error
call npm run test || goto :error

3 changes: 2 additions & 1 deletion .kokoro/test.sh
Original file line number Diff line number Diff line change
@@ -22,4 +22,5 @@ cd $(dirname $0)/..

npm install
npm test
node_modules/.bin/codecov

bash $KOKORO_GFILE_DIR/codecov.sh
42 changes: 42 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -4,6 +4,48 @@

[1]: https://www.npmjs.com/package/gax-nodejs?activeTab=versions

## v0.21.0

### 11-10-2018 11:27 PST
This is a minor service release that largely contains updates to other modules. The upgrade to `google-proto-files` and `walkdir` in particular should improve load time of the module by at least ~100ms.

### Dependencies
- fix(deps): update dependency google-proto-files to ^0.18.0 ([#348](https://github.com/googleapis/gax-nodejs/pull/348))
- fix: use `walkdir` instead of `globby` ([#346](https://github.com/googleapis/gax-nodejs/pull/346))
- chore(deps): update dependency through2 to v3 ([#343](https://github.com/googleapis/gax-nodejs/pull/343))
- chore: update grpc to ^1.15.1 ([#316](https://github.com/googleapis/gax-nodejs/pull/316))
- fix(deps): update dependency @grpc/grpc-js to ^0.3.0 ([#308](https://github.com/googleapis/gax-nodejs/pull/308))

### Internal / Testing Changes
- fix: improve types, remove dead code ([#340](https://github.com/googleapis/gax-nodejs/pull/340))
- refactor: enable noImplicitThis in the tsconfig ([#347](https://github.com/googleapis/gax-nodejs/pull/347))
- refactor: drop extend and lodash.flatten ([#345](https://github.com/googleapis/gax-nodejs/pull/345))
- chore: remove temporary folder ([#339](https://github.com/googleapis/gax-nodejs/pull/339))
- chore: use latest npm on Windows ([#344](https://github.com/googleapis/gax-nodejs/pull/344))
- refactor: clean up lodash and use strict ([#342](https://github.com/googleapis/gax-nodejs/pull/342))
- chore: include build in eslintignore ([#337](https://github.com/googleapis/gax-nodejs/pull/337))
- chore: system tests for gax ([#334](https://github.com/googleapis/gax-nodejs/pull/334))
- chore: update issue templates ([#333](https://github.com/googleapis/gax-nodejs/pull/333))
- Update issue templates
- chore: remove old issue template ([#329](https://github.com/googleapis/gax-nodejs/pull/329))
- build: run tests on node11 ([#327](https://github.com/googleapis/gax-nodejs/pull/327))
- fix: better types for GAPIC clients ([#326](https://github.com/googleapis/gax-nodejs/pull/326))
- chores(build): do not collect sponge.xml from windows builds ([#325](https://github.com/googleapis/gax-nodejs/pull/325))
- chores(build): run codecov on continuous builds ([#324](https://github.com/googleapis/gax-nodejs/pull/324))
- chore: update new issue template ([#323](https://github.com/googleapis/gax-nodejs/pull/323))
- build: fix codecov uploading on Kokoro ([#320](https://github.com/googleapis/gax-nodejs/pull/320))
- fix(deps): update dependency google-proto-files to ^0.17.0 ([#317](https://github.com/googleapis/gax-nodejs/pull/317))
- chore(deps): update dependency sinon to v7 ([#319](https://github.com/googleapis/gax-nodejs/pull/319))
- Update kokoro config ([#315](https://github.com/googleapis/gax-nodejs/pull/315))
- chore(deps): update dependency typescript to ~3.1.0 ([#313](https://github.com/googleapis/gax-nodejs/pull/313))
- Update CI config ([#312](https://github.com/googleapis/gax-nodejs/pull/312))
- build: prevent system/sample-test from leaking credentials
- Update the kokoro config ([#309](https://github.com/googleapis/gax-nodejs/pull/309))
- test: remove appveyor config ([#307](https://github.com/googleapis/gax-nodejs/pull/307))
- Update CI config ([#306](https://github.com/googleapis/gax-nodejs/pull/306))
- Enable prefer-const in the eslint config ([#304](https://github.com/googleapis/gax-nodejs/pull/304))
- Enable no-var in eslint ([#303](https://github.com/googleapis/gax-nodejs/pull/303))

## v0.18.0

### Implementation Changes
4 changes: 4 additions & 0 deletions codecov.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
codecov:
ci:
- source.cloud.google.com
Loading