Support tangentialPressure and twist fields of pointer events #13374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
approved these changes
Aug 12, 2018
There was a problem hiding this comment.
Thanks for the PR! 🎉
This seems like an oversight on my end. Those properties are in the spec since 2016 - the oldest version I could find. I think we should support them as well. 👍
motiz88
added a commit
to motiz88/flow
that referenced
this pull request
Aug 12, 2018
facebook/react#13374 has been merged so the next React DOM release will have these fields.
motiz88
added a commit
to motiz88/flow
that referenced
this pull request
Aug 12, 2018
facebook/react#13374 has been merged so the next React DOM release will have these fields.
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Sep 5, 2018
Summary: Closes #6373, closes #3227. The definition of `SyntheticPointerEvent` here was originally based on facebook/react#12507 (released in React DOM 16.4.0) which was missing a couple of fields (`twist` and `tangentialPressure`) from the official spec. I've now updated this branch to include those fields, since facebook/react#13374 has been merged. However, for maximum correctness we should probably wait for that to be _released_ before releasing the corresponding type definitions. I'll update this notice once the relevant React DOM release happens. Pull Request resolved: #6728 Reviewed By: fishythefish Differential Revision: D9338459 Pulled By: mrkev fbshipit-source-id: 263f4922e8a6765e4a2d6553b5af785bdc65a894
Merged
This was referenced Sep 7, 2018
gaearon
pushed a commit
to reactjs/react.dev
that referenced
this pull request
Sep 8, 2018
Added to `SyntheticPointerEvent` in facebook/react#13374
This was referenced Sep 10, 2018
This was referenced Nov 1, 2018
OhIAmFine
pushed a commit
to OhIAmFine/zh-hans.reactjs.org
that referenced
this pull request
May 6, 2019
Added to `SyntheticPointerEvent` in facebook/react#13374
7 tasks
RyanCavanaugh
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on facebook/flow#6728 I noticed React's recently-added
SyntheticPointerEventwas missing thetangentialPressureandtwistfields. I couldn't find any reason for their omission in #12507 (nor in the spec) so I assume they were meant to be included, like the rest ofPointerEvent. This PR adds these two fields toSyntheticPointerEvent.