Skip to content

Conversation

not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Dec 10, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

This updates the issue templates to ensure that the triage label is added to new issues. The bot had stopped adding the triage label to issues as an unintended side-effect of #11163.

(fixes eslint/eslint-github-bot#99)

Is there anything you'd like reviewers to focus on?

Nothing in particular

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 10, 2018
@not-an-aardvark not-an-aardvark added bug ESLint is working incorrectly documentation Relates to ESLint's documentation infrastructure Relates to the tools used in the ESLint development process and removed triage An ESLint team member will look at this issue soon labels Dec 10, 2018
@not-an-aardvark not-an-aardvark added the evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion label Dec 10, 2018
@not-an-aardvark
Copy link
Member Author

Marking as "evaluating" because there is ongoing discussion in eslint/eslint-github-bot#99 about the right solution.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see "evaluating" removed from each issue template. As discussed in eslint/eslint-github-bot#99, I think the progression from triage -> evaluating -> accepted is important to maintain.

@not-an-aardvark
Copy link
Member Author

Updated the templates to avoid adding "evaluating".

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@not-an-aardvark not-an-aardvark merged commit d5eb108 into master Dec 12, 2018
@aladdin-add aladdin-add deleted the add-triage-label branch December 14, 2018 10:40
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 11, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion infrastructure Relates to the tools used in the ESLint development process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triage label is no longer added to issues

4 participants