Adjust grammar of error/warnings fixable #10546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
Changes grammar of stylish to read more intuitively.
platinumazure
added
bug
platinumazure
approved these changes
Jun 30, 2018
There was a problem hiding this comment.
Seems reasonable to me. LGTM, thanks @mattmischuk for contributing!
ilyavolodin
approved these changes
Jun 30, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes grammar of stylish to read more intuitively.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Adjusting a potentially confusing CLI message. Where (when reading quickly) a user may be confused about how many errors/warnings are potentially fixable with the
--fixoption. A comma may imply a new statement whereas and continues the existing one. See below it’s not immediately clear if there are three errors or six warnings or nine.3 errors, 6 warnings potentially fixable with the `--fix` option.What changes did you make? (Give an overview)
Changed CLI output and to remove the comma in favour of an
and.Is there anything you'd like reviewers to focus on?
Nope.