Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve the docs #722

Merged
merged 2 commits into from Jan 2, 2019
Merged

Conversation

liquidslr
Copy link
Contributor

What kind of change does this PR introduce?

This PR improves the existing documentation
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Yes
Summary
Updated CONTRIBUTING.md and MIGRATE.md

Does this PR introduce a breaking change?

No
Other information

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaurav9825. Just one change rest LGTM.

MIGRATE.md Outdated Show resolved Hide resolved
@jsf-clabot
Copy link

jsf-clabot commented Jan 2, 2019

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link

@gaurav9825 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

@liquidslr
Copy link
Contributor Author

@evenstensberg can you merge these changes

@evenstensberg
Copy link
Member

need 2 approved PR's from cli team, @webpack/cli-team

@ematipico ematipico merged commit 4b2a127 into webpack:master Jan 2, 2019
@liquidslr liquidslr deleted the feature/improve-docs branch January 2, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants