misc: reduce hop for creating an issue #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemal7735
changed the title
rishabh3112
requested changes
Dec 28, 2018
evenstensberg
requested changes
Dec 28, 2018
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
Co-Authored-By: hemal7735 <hemal.patel7735@outlook.com>
|
Got it. |
hemal7735
force-pushed
the
better-issue-location
branch
from
75b4e47
to
b274db5
Compare
dhruvdutt
approved these changes
Dec 28, 2018
webpack-bot
added
PR: reviewed-approved
PR: CI-ok
and removed
PR: review-outdated
PR: CI-not-ok
labels
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
It is a GitHub co-commit feature, where suggestions can be directly committed, and it will show both names. In this case yours (suggested changes) and mine (accepted changes) |
|
Well changed my comment accordingly. |
ematipico
approved these changes
Dec 28, 2018
evenstensberg
approved these changes
Dec 28, 2018
rishabh3112
approved these changes
Dec 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is more of a feasibility kind of change for the benefit of Issue Raiser. Please feel free to close this PR if it adds a noise.
Currently, when we face any issue while running transformation we throw an error giving an URL
https://github.com/webpack/webpack-cli/issues
However, the bug reporter has to do one more hop to create an issue.
This PR changes that URL to https://github.com/webpack/webpack-cli/issues/new?template=Bug_report.md
Did you add tests for your changes? NA
If relevant, did you update the documentation? NA
Does this PR introduce a breaking change? NO