Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tasks for publishing results #695

Merged
merged 2 commits into from Nov 21, 2018

Conversation

vagisha-nidhi
Copy link
Contributor

@vagisha-nidhi vagisha-nidhi commented Nov 20, 2018

What kind of change does this PR introduce?

This PR is related to the issue #694
The PR helps to publish test results for reporting in Azure Pipelines.

Did you add tests for your changes?
No

If relevant, did you update the documentation?

Summary

Azure Pipelines provides excellent reporting capabilities that can be leveraged by this PR.
An example report is shown in the image below.
image
A screenshot for code coverage :
image

Does this PR introduce a breaking change?

No
Other information

@jsf-clabot
Copy link

jsf-clabot commented Nov 20, 2018

CLA assistant check
All committers have signed the CLA.

@hemal7735
Copy link
Member

LGTM 👍
@vagisha-nidhi can you also provide some screenshot for coverage if possible?

@vagisha-nidhi
Copy link
Contributor Author

@hemal7735 Sure. I have added the screenshot in the description. Can we requeue the travis CI integration?

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sokra is this something worth having in webpack as well?

@vagisha-nidhi
Copy link
Contributor Author

@evenstensberg Can we requeue the travis CI? There seems no evident reason why this would fail.

@ematipico
Copy link
Contributor

@vagisha-nidhi the commit message doesn't follow the pattern, that's why the CI is failing. https://github.com/webpack/webpack-cli/blob/master/CONTRIBUTING.md#commit-message-format-1

If you can rewrite your message, it would be great. If you can't, it's not a problem, we can rewrite the commit message when you we will merge your PR into master! :)

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

P.S.(off topic) I joined DTU B.Tech IT this year (you are too from DTU). Any ideas what should I do this winter @vagisha-nidhi?

@webpack-bot
Copy link

@vagisha-nidhi Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@dhruvdutt Please review the new changes.

@ematipico ematipico merged commit 0315e04 into webpack:master Nov 21, 2018
@evenstensberg
Copy link
Member

Do you have a link of this working atm? Can't seem to find it

@ematipico
Copy link
Contributor

@rishabh3112
Copy link
Member

For each PR here
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants