Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Find config recursively #689

Closed
GMartigny opened this issue Nov 13, 2018 · 2 comments
Closed

Feature: Find config recursively #689

GMartigny opened this issue Nov 13, 2018 · 2 comments

Comments

@GMartigny
Copy link

Is your feature request related to a problem? Please describe.
Unlike shellscape/webpack-command (formerly webpack-contrib/webpack-command) configuration file is not searched upward in the directory tree. When using monorepo, I would like to set one configuration's file at the root and not for each sub-modules.

Describe the solution you'd like
Being able to define only one webpack configuration file for all sub-modules of a mono-repo.

Describe alternatives you've considered
I could use shellscape/webpack-command, but I would like to stay within the official repo.
I could set symbolic links, but it feels overkills.

Additional context
File ./webpack.config.js exists.
Scripts in ./packages/sub/package.json:

"build:cli": "webpack-cli --mode=production",
"build:com": "webpack-command --mode=production"

Running lerna run build:cli fail to read ./webpack.config.js, but lerna run build:com works.

This feature could change existing behavior, but it seems closer to what could be expected. (works alike git config)

@lakatostamas
Copy link
Contributor

Hi!
Can I send a PR for this?

@dhruvdutt
Copy link
Member

dhruvdutt commented Nov 17, 2018

Absolutely, go ahead. 👍

lakatostamas pushed a commit to lakatostamas/webpack-cli that referenced this issue Nov 18, 2018
lakatostamas pushed a commit to lakatostamas/webpack-cli that referenced this issue Nov 18, 2018
lakatostamas pushed a commit to lakatostamas/webpack-cli that referenced this issue Nov 18, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Nov 18, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Nov 18, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Nov 18, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Nov 18, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Nov 19, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Nov 19, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Nov 23, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Nov 23, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Nov 26, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Dec 7, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Dec 7, 2018
lakatostamas added a commit to lakatostamas/webpack-cli that referenced this issue Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants