Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Fix typos and improve intro wording #687

Merged
merged 1 commit into from Nov 8, 2018

Conversation

atenni
Copy link
Contributor

@atenni atenni commented Nov 7, 2018

What kind of change does this PR introduce?
Simple documentation fixes.

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
...yes :)

Summary
Fixes typos and changes wording for better readability – particularly the last sentence which I couldn't understand.

@jsf-clabot
Copy link

jsf-clabot commented Nov 7, 2018

CLA assistant check
All committers have signed the CLA.

@atenni atenni changed the title Fix typos and improve intro wording [Docs]: Fix typos and improve intro wording Nov 7, 2018
@webpack-bot
Copy link

@atenni The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from travis (failure) and fix these issues.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gold, thanks for your PR! 😋🌻 lgtm

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now !!

@ematipico ematipico merged commit 8dba736 into webpack:master Nov 8, 2018
@atenni atenni deleted the patch-1 branch November 8, 2018 10:39
Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants