Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add nproc in azure #677

Merged
merged 2 commits into from Nov 4, 2018
Merged

chore: add nproc in azure #677

merged 2 commits into from Nov 4, 2018

Conversation

evenstensberg
Copy link
Member

@evenstensberg evenstensberg commented Nov 4, 2018

What kind of change does this PR introduce?
Fixes nproc on azure

Did you add tests for your changes?
Y
If relevant, did you update the documentation?
N/A
Summary
N/A

Does this PR introduce a breaking change?
No

Other information
:)

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad syntax. Are you sure it's correct?

@evenstensberg
Copy link
Member Author

Working on it...

Copy link
Member Author

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenstensberg
Copy link
Member Author

Looks good on Azure now, PTAL @ematipico

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@ematipico ematipico merged commit 04f1f24 into master Nov 4, 2018
@dhruvdutt dhruvdutt deleted the fix/azure branch November 4, 2018 07:56
dhruvdutt pushed a commit that referenced this pull request Nov 4, 2018
* chore: add nproc in azure

* chore: try using vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants