Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): pin to webpack 4.x.x #658

Merged
merged 4 commits into from Oct 28, 2018

Conversation

dhruvdutt
Copy link
Member

What kind of change does this PR introduce?
Update dependencies

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary
Pin webpack version to 4.x.x everywhere. If we include ~ or ^, greenkeeper will try to update every new version of webpack.

#655 Greenkeeper did not create a PR since the initial build failed and after updating to the newer version, it did not create a PR automatically, only updated the code on its branch.

Does this PR introduce a breaking change?
No

Other information
Closes #655, #656

@jsf-clabot

This comment has been minimized.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🍏

@dhruvdutt dhruvdutt force-pushed the greenkeeper/default/webpack-4.23.1 branch from 1781e2a to abc9702 Compare October 28, 2018 12:49
@webpack-bot

This comment has been minimized.

@dhruvdutt dhruvdutt merged commit 20a2598 into master Oct 28, 2018
@greenkeeper greenkeeper bot deleted the greenkeeper/default/webpack-4.23.1 branch October 28, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants