Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix critical error #631

Merged
merged 1 commit into from Oct 8, 2018
Merged

fix critical error #631

merged 1 commit into from Oct 8, 2018

Conversation

letstri
Copy link

@letstri letstri commented Oct 7, 2018 •
edited

Very important error!

@jsf-clabot
Copy link

jsf-clabot commented Oct 7, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@letstri letstri changed the title minor change fix critical error Oct 7, 2018
evenstensberg
evenstensberg approved these changes Oct 7, 2018
View reviewed changes
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato! Lgtm here, do you mind signing the CLA? Bound to JSF for legal reasons. Aftee that this is lgtm!

@webpack-bot
Copy link

@BrooonS The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from travis (failure) and fix these issues.

@dhruvdutt
Copy link
Member

@BrooonS Can you please sign CLA?

@dhruvdutt dhruvdutt merged commit 91b45ab into webpack:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@dhruvdutt dhruvdutt dhruvdutt approved these changes

@evenstensberg evenstensberg evenstensberg approved these changes

Assignees
No one assigned
Labels
PR: CI-not-ok PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@letstri @jsf-clabot @webpack-bot @dhruvdutt @ematipico @evenstensberg