Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/init Vulnerability Issue at npm release 0.1.2 #721

Closed
eavichay opened this issue Jan 1, 2019 · 3 comments
Closed

cli/init Vulnerability Issue at npm release 0.1.2 #721

eavichay opened this issue Jan 1, 2019 · 3 comments

Comments

@eavichay
Copy link
Contributor

eavichay commented Jan 1, 2019 •
edited

Describe the bug

npm audit fails on @webpack-cli/init ^0.1.2

To Reproduce

package.json

"devDependencies": {
  "@webpack-cli/init": "^0.1.2"
}
$ npm audit

Revelas 1 high severity issue: @webpack-cli/init > @webpack-cli/generators > webpack-dev-server

more info: https://nodesecurity.io/advisories/725

Should upgrade the dev-server to a higher version > 3.1.6+

Expected behavior
Pass the npm-audit
@eavichay
Copy link
Contributor Author

eavichay commented Jan 1, 2019

Our CI/CD server does not permit audit failures, unfortunately even for dev-dependencies.

@ematipico
Copy link
Contributor

PR is welcome! 😄

eavichay added a commit to eavichay/webpack-cli that referenced this issue Jan 2, 2019
@eavichay
See webpack#721
9ad8c1d
@eavichay eavichay mentioned this issue Jan 2, 2019
Merged
@eavichay
Copy link
Contributor Author

eavichay commented Jan 2, 2019

@ematipico Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ematipico @eavichay