fix(upgrade): fix breaking changes for yeoman-generator

webpack · Oct 26, 2018 · f057ecf · f057ecf
1 parent cefe6b3
commit f057ecf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/generators/add-generator.ts b/packages/generators/add-generator.ts
@@ -432,7 +432,7 @@ export default class AddGenerator extends Generator {
 									] = `new ${pluginName}`;
 									this.configuration.config.item = answerToAction.actionAnswer;
 									done();
-									this.runInstall(getPackageManager(), this.dependencies, {
+									this.scheduleInstallTask(getPackageManager(), this.dependencies, {
 										"save-dev": true,
 									});
 								} else {

diff --git a/packages/generators/addon-generator.ts b/packages/generators/addon-generator.ts
@@ -75,9 +75,11 @@ export default function addonGenerator(
 		public install() {
 			this.npmInstall(["webpack-defaults", "bluebird"], {
 				"save-dev": true,
-			}).then((_: void): void => {
-				this.spawnCommand("npm", ["run", "defaults"]);
 			});
 		}
+
+		public end() {
+			this.spawnCommand("npm", ["run", "defaults"]);
+		}
 	};
 }
diff --git a/packages/generators/init-generator.ts b/packages/generators/init-generator.ts
@@ -439,7 +439,7 @@ export default class InitGenerator extends Generator {
 			dev?: boolean,
 			"save-dev"?: boolean,
 		} = packager === "yarn" ? { dev: true } : { "save-dev": true };
-		this.runInstall(packager, this.dependencies, opts);
+		this.scheduleInstallTask(packager, this.dependencies, opts);
 	}
 
 	public writing() {