fix: regenerate contenthash when assets was minified
#386
Conversation
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 98.52% 98.56% +0.03%
==========================================
Files 5 5
Lines 272 278 +6
Branches 107 107
==========================================
+ Hits 268 274 +6
Misses 4 4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 98.52% 98.56% +0.03%
==========================================
Files 5 5
Lines 272 278 +6
Branches 107 107
==========================================
+ Hits 268 274 +6
Misses 4 4
Continue to review full report at Codecov.
|
alexander-akait
deleted the
fix-regenerate-contenthash-when-assets-was-minified
branch
| // We have 1 async chunk (1 * 2 = 2 calls for ChunkTemplate) | ||
| expect(mockMainTemplateUpdateHashForChunk).toHaveBeenCalledTimes(8); | ||
| // We have 4 initial chunks (4 * 2 = 8 calls for MainTemplate) | ||
| expect(mockChunkTemplateUpdateHashFocChunk).toHaveBeenCalledTimes(2); |
There was a problem hiding this comment.
Are the comments and codes in wrong order?
There was a problem hiding this comment.
@hsxfjames oh, sorry, feel free to send a PR with fix
This PR contains a:
Motivation / Use-Case
Regenerate
contenthashwhen assets was minifiedBreaking Changes
No
Additional Info
No