Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

fix(index): handle chunks provided as a {Set} #365

Merged
merged 1 commit into from Oct 12, 2018

Conversation

ooflorent
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

In webpack@5, chunks is a Set and thus should be converted to an array.

Breaking Changes

n/a

Additional Info

This change makes the plugin compatible with webpack 4 and 5.

@alexander-akait alexander-akait changed the title fix: chunks is a Set in webpack@5 fix(index): handle chunks provided as a {Set} Oct 12, 2018
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files           5        5           
  Lines         260      260           
  Branches      102      102           
=======================================
  Hits          254      254           
  Misses          6        6
Impacted Files Coverage Δ
src/index.js 96.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96cfdb5...aa4067f. Read the comment docs.

@alexander-akait alexander-akait merged commit bf36e21 into master Oct 12, 2018
@alexander-akait alexander-akait deleted the fix/chunks-deprecation branch October 12, 2018 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants