Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Commit

Permalink
feat: chunkFilter option for filtering chunks (#382)
Browse files Browse the repository at this point in the history
  • Loading branch information
@evilebottnawi
evilebottnawi committed Dec 17, 2018
1 parent 1282b87 commit 1e58c99
Show file tree
Hide file tree
Showing 7 changed files with 210 additions and 6 deletions.
29 changes: 29 additions & 0 deletions README.md
View file
Expand Up @@ -109,6 +109,35 @@ module.exports = {
};
```

### `chunkFilter`

Type: `Function<(chunk) -> boolean>`
Default: `() => true`

Allowing to filter which chunks should be uglified (by default all chunks are uglified).
Return `true` to uglify the chunk, `false` otherwise.

**webpack.config.js**

```js
module.exports = {
optimization: {
minimizer: [
new UglifyJsPlugin({
chunkFilter: (chunk) => {
// Exclude uglification for the `vendor` chunk
if (chunk.name === 'vendor') {
return false;
}

return true;
}
}),
],
},
};
```

### `cache`

Type: `Boolean|String`
Expand Down
5 changes: 5 additions & 0 deletions src/index.js
View file
Expand Up @@ -23,6 +23,7 @@ class UglifyJsPlugin {
minify,
uglifyOptions = {},
test = /\.js(\?.*)?$/i,
chunkFilter = () => true,
warningsFilter = () => true,
extractComments = false,
sourceMap = false,
Expand All @@ -35,6 +36,7 @@ class UglifyJsPlugin {

this.options = {
test,
chunkFilter,
warningsFilter,
extractComments,
sourceMap,
Expand Down Expand Up @@ -165,7 +167,10 @@ class UglifyJsPlugin {
const processedAssets = new WeakSet();
const tasks = [];

const { chunkFilter } = this.options;

Array.from(chunks)
.filter((chunk) => chunkFilter && chunkFilter(chunk))
.reduce((acc, chunk) => acc.concat(chunk.files || []), [])
.concat(compilation.additionalChunkAssets || [])
.filter(ModuleFilenameHelpers.matchObject.bind(null, this.options))
Expand Down
3 changes: 3 additions & 0 deletions src/options.json
View file
Expand Up @@ -64,6 +64,9 @@
}
]
},
"chunkFilter": {
"instanceof": "Function"
},
"cache": {
"anyOf": [
{
Expand Down
108 changes: 108 additions & 0 deletions test/__snapshots__/chunkFilter-option.test.js.snap
View file
@@ -0,0 +1,108 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`when applied with \`chunkFilter\` option matches snapshot for a single \`chunkFilter\`: entry.dd5931aa48f58d803916.js 1`] = `"!function(n){var r={};function o(e){if(r[e])return r[e].exports;var t=r[e]={i:e,l:!1,exports:{}};return n[e].call(t.exports,t,t.exports,o),t.l=!0,t.exports}o.m=n,o.c=r,o.d=function(e,t,n){o.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},o.r=function(e){\\"undefined\\"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:\\"Module\\"}),Object.defineProperty(e,\\"__esModule\\",{value:!0})},o.t=function(t,e){if(1&e&&(t=o(t)),8&e)return t;if(4&e&&\\"object\\"==typeof t&&t&&t.__esModule)return t;var n=Object.create(null);if(o.r(n),Object.defineProperty(n,\\"default\\",{enumerable:!0,value:t}),2&e&&\\"string\\"!=typeof t)for(var r in t)o.d(n,r,function(e){return t[e]}.bind(null,r));return n},o.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return o.d(t,\\"a\\",t),t},o.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},o.p=\\"\\",o(o.s=1)}([,function(e,t){e.exports=function(){console.log(7)}}]);"`;

exports[`when applied with \`chunkFilter\` option matches snapshot for a single \`chunkFilter\`: errors 1`] = `Array []`;

exports[`when applied with \`chunkFilter\` option matches snapshot for a single \`chunkFilter\`: included.246349b8cbc039f3eb25.js 1`] = `
"/******/ (function(modules) { // webpackBootstrap
/******/ // The module cache
/******/ var installedModules = {};
/******/
/******/ // The require function
/******/ function __webpack_require__(moduleId) {
/******/
/******/ // Check if module is in cache
/******/ if(installedModules[moduleId]) {
/******/ return installedModules[moduleId].exports;
/******/ }
/******/ // Create a new module (and put it into the cache)
/******/ var module = installedModules[moduleId] = {
/******/ i: moduleId,
/******/ l: false,
/******/ exports: {}
/******/ };
/******/
/******/ // Execute the module function
/******/ modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);
/******/
/******/ // Flag the module as loaded
/******/ module.l = true;
/******/
/******/ // Return the exports of the module
/******/ return module.exports;
/******/ }
/******/
/******/
/******/ // expose the modules object (__webpack_modules__)
/******/ __webpack_require__.m = modules;
/******/
/******/ // expose the module cache
/******/ __webpack_require__.c = installedModules;
/******/
/******/ // define getter function for harmony exports
/******/ __webpack_require__.d = function(exports, name, getter) {
/******/ if(!__webpack_require__.o(exports, name)) {
/******/ Object.defineProperty(exports, name, { enumerable: true, get: getter });
/******/ }
/******/ };
/******/
/******/ // define __esModule on exports
/******/ __webpack_require__.r = function(exports) {
/******/ if(typeof Symbol !== 'undefined' && Symbol.toStringTag) {
/******/ Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
/******/ }
/******/ Object.defineProperty(exports, '__esModule', { value: true });
/******/ };
/******/
/******/ // create a fake namespace object
/******/ // mode & 1: value is a module id, require it
/******/ // mode & 2: merge all properties of value into the ns
/******/ // mode & 4: return value when already ns object
/******/ // mode & 8|1: behave like require
/******/ __webpack_require__.t = function(value, mode) {
/******/ if(mode & 1) value = __webpack_require__(value);
/******/ if(mode & 8) return value;
/******/ if((mode & 4) && typeof value === 'object' && value && value.__esModule) return value;
/******/ var ns = Object.create(null);
/******/ __webpack_require__.r(ns);
/******/ Object.defineProperty(ns, 'default', { enumerable: true, value: value });
/******/ if(mode & 2 && typeof value != 'string') for(var key in value) __webpack_require__.d(ns, key, function(key) { return value[key]; }.bind(null, key));
/******/ return ns;
/******/ };
/******/
/******/ // getDefaultExport function for compatibility with non-harmony modules
/******/ __webpack_require__.n = function(module) {
/******/ var getter = module && module.__esModule ?
/******/ function getDefault() { return module['default']; } :
/******/ function getModuleExports() { return module; };
/******/ __webpack_require__.d(getter, 'a', getter);
/******/ return getter;
/******/ };
/******/
/******/ // Object.prototype.hasOwnProperty.call
/******/ __webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };
/******/
/******/ // __webpack_public_path__
/******/ __webpack_require__.p = \\"\\";
/******/
/******/
/******/ // Load entry module and return exports
/******/ return __webpack_require__(__webpack_require__.s = 0);
/******/ })
/************************************************************************/
/******/ ([
/* 0 */
/***/ (function(module, exports) {
module.exports = function Bar1() {
var b = 2 + 2;
console.log(b + 1 + 2);
};
/***/ })
/******/ ]);"
`;

exports[`when applied with \`chunkFilter\` option matches snapshot for a single \`chunkFilter\`: warnings 1`] = `Array []`;
19 changes: 13 additions & 6 deletions test/__snapshots__/validation.test.js.snap
View file
Expand Up @@ -3,20 +3,27 @@
exports[`validation 1`] = `
"UglifyJs Plugin Invalid Options
options should NOT have additional properties
options.chunkFilter should pass \\"instanceof\\" keyword validation
"
`;

exports[`validation 2`] = `
"UglifyJs Plugin Invalid Options
options should NOT have additional properties
"
`;

exports[`validation 3`] = `
"UglifyJs Plugin Invalid Options
options.cache should be boolean
options.cache should be string
options.cache should match some schema in anyOf
"
`;

exports[`validation 3`] = `
exports[`validation 4`] = `
"UglifyJs Plugin Invalid Options
options.parallel should be boolean
Expand All @@ -25,7 +32,7 @@ options.parallel should match some schema in anyOf
"
`;

exports[`validation 4`] = `
exports[`validation 5`] = `
"UglifyJs Plugin Invalid Options
options.parallel should be boolean
Expand All @@ -34,21 +41,21 @@ options.parallel should match some schema in anyOf
"
`;

exports[`validation 5`] = `
exports[`validation 6`] = `
"UglifyJs Plugin Invalid Options
options.sourceMap should be boolean
"
`;

exports[`validation 6`] = `
exports[`validation 7`] = `
"UglifyJs Plugin Invalid Options
options.uglifyOptions should be object
"
`;

exports[`validation 7`] = `
exports[`validation 8`] = `
"UglifyJs Plugin Invalid Options
options.warningsFilter should pass \\"instanceof\\" keyword validation
Expand Down
44 changes: 44 additions & 0 deletions test/chunkFilter-option.test.js
View file
@@ -0,0 +1,44 @@
import UglifyJsPlugin from '../src/index';

import { cleanErrorStack, createCompiler, compile } from './helpers';

describe('when applied with `chunkFilter` option', () => {
let compiler;

beforeEach(() => {
compiler = createCompiler({
entry: {
included: `${__dirname}/fixtures/included1.js`,
entry: `${__dirname}/fixtures/entry.js`,
},
});
});

it('matches snapshot for a single `chunkFilter`', () => {
new UglifyJsPlugin({
chunkFilter: (chunk) => {
if (chunk.name === 'included') {
return false;
}

return true;
},
}).apply(compiler);

return compile(compiler).then((stats) => {
const errors = stats.compilation.errors.map(cleanErrorStack);
const warnings = stats.compilation.warnings.map(cleanErrorStack);

expect(errors).toMatchSnapshot('errors');
expect(warnings).toMatchSnapshot('warnings');

for (const file in stats.compilation.assets) {
if (
Object.prototype.hasOwnProperty.call(stats.compilation.assets, file)
) {
expect(stats.compilation.assets[file].source()).toMatchSnapshot(file);
}
}
});
});
});
8 changes: 8 additions & 0 deletions test/validation.test.js
View file
Expand Up @@ -26,6 +26,14 @@ it('validation', () => {
new UglifyJsPlugin({ exclude: [/foo/] });
}).not.toThrow();

expect(() => {
new UglifyJsPlugin({ chunkFilter: () => {} });
}).not.toThrow();

expect(() => {
new UglifyJsPlugin({ chunkFilter: true });
}).toThrowErrorMatchingSnapshot();

expect(() => {
new UglifyJsPlugin({ doesntExist: true });
}).toThrowErrorMatchingSnapshot();
Expand Down

0 comments on commit 1e58c99

Please sign in to comment.