Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCombobox): menu position may not update if multiple #5888

Merged
merged 3 commits into from Dec 18, 2018
Merged

fix(VCombobox): menu position may not update if multiple #5888

merged 3 commits into from Dec 18, 2018

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Dec 13, 2018

Description

There is method onInternalSearchChanged in v-combobox. If combobox has multiple prop, then this method may return earlier than method updateMenuDimensions is called. It is the reason for issue #5082. This pr change onInternalSearchChanged method, so now updateMenuDimensions will always be called.

Motivation and Context

Fix #5082

How Has This Been Tested?

visually

Markup:

<template>
  <v-layout
    class="wrapper"
    align-end
  >
    <v-combobox
      chips
      multiple
      v-model="model"
      :items="items"
    />

    <v-spacer />

    <v-combobox
      chips
      multiple
      v-model="model"
      :items="items"
      :delimiters="[',']"
    />
  </v-layout>
</template>

<style scoped>
  .wrapper {
    height: 95vh;
  }
</style>

<script>
  export default {
    data: () => ({
      items: ['Gaming', 'Programming', 'Vue', 'Vuetify'],
      model: ['Vuetify'],
    }),
  };
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel
Copy link

vercel bot commented Dec 13, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #5888 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5888   +/-   ##
=======================================
  Coverage   89.14%   89.14%           
=======================================
  Files         262      262           
  Lines        5915     5915           
  Branches     1468     1468           
=======================================
  Hits         5273     5273           
  Misses        528      528           
  Partials      114      114
Impacted Files Coverage Δ
...ages/vuetify/src/components/VCombobox/VCombobox.js 97.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e842a40...ce59558. Read the comment docs.

KaelWD and others added 2 commits December 13, 2018 19:43
Co-Authored-By: dima74 <diraria@yandex.ru>
@KaelWD KaelWD added this to the v1.3.x milestone Dec 15, 2018
@KaelWD KaelWD merged commit a1065ca into vuetifyjs:master Dec 18, 2018
@dima74 dima74 deleted the fix/5082 branch December 20, 2018 09:34
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Multiple combobox doesn't adjust the top style of suggestions
2 participants