Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VProgressCircular): fix type check for width prop #5875

Merged
merged 3 commits into from Dec 12, 2018

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Dec 12, 2018

Description

Add String type to width property

Motivation and Context

Fixes #5874

How Has This Been Tested?

Visually

Markup:

<template>
  <v-app>
    <v-progress-circular color="primary" size="160" value="100" width="10">
      <v-layout column align-center>
        <v-flex xs12>
          <h4>Trays</h4>
        </v-flex>
        <v-flex xs12>
          <h4 id="vs"></h4>
        </v-flex>
      </v-layout>
    </v-progress-circular>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel
Copy link

vercel bot commented Dec 12, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #5875 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5875      +/-   ##
==========================================
+ Coverage   89.19%   89.21%   +0.01%     
==========================================
  Files         262      262              
  Lines        5915     5915              
  Branches     1467     1467              
==========================================
+ Hits         5276     5277       +1     
+ Misses        525      524       -1     
  Partials      114      114
Impacted Files Coverage Δ
.../components/VProgressCircular/VProgressCircular.ts 100% <100%> (ø) ⬆️
...fy/src/components/transitions/expand-transition.js 76% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae31593...00b41ed. Read the comment docs.

@jacekkarczmarczyk
Copy link
Member

Same could be done with rotate prop

Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@MajesticPotatoe MajesticPotatoe merged commit e7eccfc into vuetifyjs:master Dec 12, 2018
@dsseng dsseng deleted the fix/#5874 branch December 12, 2018 13:12
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Circular Progress Bar
3 participants