Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kbd): fix kbd background color #5864

Merged
merged 1 commit into from Dec 11, 2018

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Dec 11, 2018

Description

Change kbd background to $grey.darken-2

Motivation and Context

Fixes #5509.

How Has This Been Tested?

visually

Markup:

<template>
  <v-app>
    <v-container>
      <v-card dark>
        <v-card-text>
          im some card text<br>
          <kbd>im a kbd tag</kbd>
          <code>im a code tag</code>
        </v-card-text>
      </v-card>
      <v-card>
        <v-card-text>
          im some card text<br>
          <kbd>im a kbd tag</kbd>
          <code>im a code tag</code>
        </v-card-text>
      </v-card>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel
Copy link

vercel bot commented Dec 11, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍
Thanks for the contribution.

@MajesticPotatoe MajesticPotatoe merged commit 28f61b5 into vuetifyjs:master Dec 11, 2018
@dsseng dsseng deleted the fix/#5509 branch December 11, 2018 13:07
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] kbd tag background color inside card or menu on dark theme is same as background
2 participants