fix(VMenu): hover stuck open when mouse exits page

[parktheredcar]

Description

It's possible for a mouseLeaveEvent to finish closing a menu before the corresponding mouseEnterEvent's animation frame has run, resulting in a stuck open menu. I have added some logic to double check at and make sure the menu is still active at the time the animation frame runs.

In this situation, isActive has been reset to false between the time runDelay(open) was called and when we were provisioned this animation frame, sync up hasJustFocused to false and do a no-op assign to isContentActive which doesn't trigger the watcher. Tried to minimize branching to match project style.

Motivation and Context

This is a fix for #5843, the issue is fully documented over there including related codepen.

How Has This Been Tested?

I have tested the hover functionality of v-menu and v-tooltip, including edge cases such as right clicking the mouse and exiting the page, and both are now working correctly.

Markup:

// Paste your FULL Playground.vue here
<template>
  <v-app>
      <v-toolbar app>
        <v-menu open-on-hover top offset-y>
          <v-btn
            slot="activator"
            color="primary"
          >
            Dropdown
          </v-btn>
          <v-list>
            <v-list-tile>
              <v-list-tile-title>List Item</v-list-tile-title>
            </v-list-tile>
          </v-list>
        </v-menu>
      </v-toolbar>
      <v-content app>
        <v-tooltip bottom>
          <span slot="activator">This text has a tooltip</span>
          <span>Tooltip</span>
        </v-tooltip>
      </v-content>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
    })
  }
</script>

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

• The PR title is no longer than 64 characters.
• The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
• My code follows the code style of this project.
• I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

[codecov]

Codecov Report

Merging #5844 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5844      +/-   ##
==========================================
- Coverage   89.07%   89.05%   -0.02%     
==========================================
  Files         262      262              
  Lines        5923     5923              
  Branches     1468     1468              
==========================================
- Hits         5276     5275       -1     
- Misses        531      532       +1     
  Partials      116      116

Impacted Files	Coverage Δ
packages/vuetify/src/mixins/menuable.js	95.28% <100%> (ø)	⬆️
...fy/src/components/transitions/expand-transition.js	60% <0%> (-4%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c1ac8...39600ac. Read the comment docs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord