New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VChip): rtl mode #5802
fix(VChip): rtl mode #5802
Conversation
fixes #5782
This pull request is automatically deployed with Now. |
|
||
&--removable | ||
.v-chip__content | ||
padding: $chip-removeable-padding-rtl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding: $chip-removeable-padding-rtl | |
padding: $chip-removable-padding-rtl |
@@ -194,11 +194,13 @@ $card-border-radius := 2px | |||
// Chip | |||
$chip-border-radius := 28px | |||
$chip-close-margin := 0 2px 0 8px | |||
$chip-close-margin-rtl := 0 8px 0 2px | |||
$chip-font-size := 13px | |||
$chip-label-border-radius := $card-border-radius | |||
$chip-icon-font-size := 20px | |||
$chip-padding := 0 12px | |||
$chip-removeable-padding := 0 4px 0 12px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it was already wrong here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably remove these and make it relate to $chip-icon-offset
and $chip-margin
instead.
Motivation and Context
fixes #5782
How Has This Been Tested?
visually
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).