Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VChip): rtl mode #5802

Merged
merged 4 commits into from Dec 9, 2018
Merged

fix(VChip): rtl mode #5802

merged 4 commits into from Dec 9, 2018

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #5782

How Has This Been Tested?

visually

Markup:

<template>
  <v-app id="inspire">
    <v-content>
      <v-container>
        <v-chip>normal</v-chip>
        <v-chip close>closable</v-chip>
        <v-chip close><v-avatar color=red>X</v-avatar>closable</v-chip>
        <v-chip><v-icon>place</v-icon>icon</v-chip>
        <v-chip><v-icon left>place</v-icon>icon left</v-chip>
        <v-chip>icon right<v-icon right>place</v-icon></v-chip>
        <v-select multiple chips :items="['foo', 'bar']" :value="['foo', 'bar']" deletable-chips />

        <v-btn @click="$vuetify.rtl = !$vuetify.rtl">Switch rtl</v-btn>
      </v-container>
    </v-content>
  </v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Dec 4, 2018
@jacekkarczmarczyk jacekkarczmarczyk added this to the v1.3.x milestone Dec 4, 2018
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Dec 4, 2018
@vercel
Copy link

vercel bot commented Dec 4, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.


&--removable
.v-chip__content
padding: $chip-removeable-padding-rtl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
padding: $chip-removeable-padding-rtl
padding: $chip-removable-padding-rtl

@@ -194,11 +194,13 @@ $card-border-radius := 2px
// Chip
$chip-border-radius := 28px
$chip-close-margin := 0 2px 0 8px
$chip-close-margin-rtl := 0 8px 0 2px
$chip-font-size := 13px
$chip-label-border-radius := $card-border-radius
$chip-icon-font-size := 20px
$chip-padding := 0 12px
$chip-removeable-padding := 0 4px 0 12px
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it was already wrong here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably remove these and make it relate to $chip-icon-offset and $chip-margin instead.

@johnleider johnleider merged commit 45da2ea into master Dec 9, 2018
@johnleider johnleider deleted the fix/#5782-chips-rtl branch December 9, 2018 20:56
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] [RTL] Chip with close prop doesn't have proper padding
3 participants