Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBadge): rtl mode #5801

Merged
merged 2 commits into from Dec 9, 2018
Merged

fix(VBadge): rtl mode #5801

merged 2 commits into from Dec 9, 2018

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #5684

How Has This Been Tested?

visually

Markup:

<template>
  <v-app id="inspire">
    <v-content>
      <v-container>
        <v-badge class="mx-5"><v-icon slot="badge">place</v-icon>default</v-badge>
        <v-badge left class="mx-5"><v-icon slot="badge">place</v-icon>left</v-badge>
        <v-badge right class="mx-5"><v-icon slot="badge">place</v-icon>right</v-badge>
        <v-divider />
        <v-badge overlap class="mx-5"><v-icon slot="badge">place</v-icon>default</v-badge>
        <v-badge overlap left class="mx-5"><v-icon slot="badge">place</v-icon>left</v-badge>
        <v-badge overlap right class="mx-5"><v-icon slot="badge">place</v-icon>right</v-badge>

        <v-btn @click="$vuetify.rtl = !$vuetify.rtl">Switch rtl</v-btn>
      </v-container>
    </v-content>
  </v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Dec 4, 2018
@jacekkarczmarczyk jacekkarczmarczyk added this to the v1.3.x milestone Dec 4, 2018
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Dec 4, 2018
@vercel
Copy link

vercel bot commented Dec 4, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #5801 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5801      +/-   ##
==========================================
+ Coverage   89.05%   89.07%   +0.01%     
==========================================
  Files         262      262              
  Lines        5923     5923              
  Branches     1468     1468              
==========================================
+ Hits         5275     5276       +1     
+ Misses        532      531       -1     
  Partials      116      116
Impacted Files Coverage Δ
...fy/src/components/transitions/expand-transition.js 64% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45da2ea...940500c. Read the comment docs.

@johnleider johnleider merged commit 7eadc37 into master Dec 9, 2018
@johnleider johnleider deleted the fix/#5684-badge-rtl branch December 9, 2018 21:03
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Badge direction issue on rtl mode
2 participants