Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] [RTL] Chip with close prop doesn't have proper padding #5782

Closed
Mohammad-Ha opened this issue Dec 2, 2018 · 0 comments · Fixed by #5802
Closed

[Bug Report] [RTL] Chip with close prop doesn't have proper padding #5782

Mohammad-Ha opened this issue Dec 2, 2018 · 0 comments · Fixed by #5802
Labels
good first issue A quick-win fix that would be great for new contributors S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@Mohammad-Ha
Copy link

Versions and Environment

Vuetify: 1.3.11
Vue: 2.5.17
Browsers: Chrome 70.0.3538.110
OS: Windows 10

Steps to reproduce

  1. Add v-chip to your template.
  2. Enable RTL.
  3. Add close prop to the v-chip.

Expected Behavior

Correct padding

Actual Behavior

LTR padding instead of RTL padding.

Reproduction Link

https://codepen.io/anon/pen/EOrRJp

Other comments

Padding's right/left values should be switched in RTL.
@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected good first issue A quick-win fix that would be great for new contributors labels Dec 2, 2018
jacekkarczmarczyk added a commit that referenced this issue Dec 4, 2018
@jacekkarczmarczyk
fix(VChip): rtl mode
6824a06 
fixes #5782
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Dec 4, 2018
Merged
8 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Dec 4, 2018
johnleider added a commit that referenced this issue Dec 9, 2018
@johnleider
Merge branch 'master' into fix/#5782-chips-rtl
9b74984
johnleider pushed a commit that referenced this issue Dec 9, 2018
@jacekkarczmarczyk @johnleider
fix(VChip): rtl mode (#5802)
45da2ea 
* fix(VChip): rtl mode

fixes #5782

* revert posible breaking change

* fixed variables
@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue A quick-win fix that would be great for new contributors S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VChip): rtl mode vuetifyjs/vuetify
2 participants
@Mohammad-Ha @jacekkarczmarczyk