Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSelect): fix VSelect behavior when switching to another tab #5780

Merged
merged 3 commits into from Dec 9, 2018

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Dec 1, 2018

Description

V-select should close when it loses focus or user switches to another tab.

Motivation and Context

Fixes #5774

How Has This Been Tested?

visually

Markup:

// Paste your FULL Playground.vue here<template>
  <v-app>
    <v-card>
      <v-container
        fluid
        grid-list-xl
      >
        <v-layout
          align-center
          wrap
        >
          <v-flex xs12 sm6>
            <v-select
              v-model="value"
              :items="items"
              attach
              chips
              label="Chips"
              multiple
            ></v-select>
          </v-flex>
          <v-flex xs12 sm6>
            <v-select
              v-model="value"
              :items="items"
              box
              chips
              label="Chips"
              multiple
            ></v-select>
          </v-flex>
          <v-flex xs12 sm6>
            <v-select
              v-model="value"
              :items="items"
              chips
              label="Chips"
              multiple
              outline
            ></v-select>
          </v-flex>
          <v-flex xs12 sm6>
            <v-select
              v-model="value"
              :items="items"
              chips
              label="Chips"
              multiple
              solo
            ></v-select>
          </v-flex>
        </v-layout>
      </v-container>
    </v-card>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      items: ['foo', 'bar', 'fizz', 'buzz'],
      value: ['foo', 'bar', 'fizz', 'buzz']
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel
Copy link

vercel bot commented Dec 1, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Dec 1, 2018

Codecov Report

Merging #5780 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5780      +/-   ##
==========================================
+ Coverage   89.07%   89.11%   +0.03%     
==========================================
  Files         262      262              
  Lines        5922     5923       +1     
  Branches     1467     1467              
==========================================
+ Hits         5275     5278       +3     
+ Misses        531      530       -1     
+ Partials      116      115       -1
Impacted Files Coverage Δ
packages/vuetify/src/components/VSelect/VSelect.js 88.53% <100%> (+0.05%) ⬆️
...tify/src/components/VAutocomplete/VAutocomplete.js 100% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb28c4...8dd8d78. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 1, 2018

Codecov Report

Merging #5780 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5780      +/-   ##
==========================================
+ Coverage   89.07%   89.11%   +0.03%     
==========================================
  Files         262      262              
  Lines        5923     5924       +1     
  Branches     1468     1468              
==========================================
+ Hits         5276     5279       +3     
+ Misses        531      530       -1     
+ Partials      116      115       -1
Impacted Files Coverage Δ
packages/vuetify/src/components/VSelect/VSelect.js 88.53% <100%> (+0.05%) ⬆️
...tify/src/components/VAutocomplete/VAutocomplete.js 100% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c1ac8...6b79ed5. Read the comment docs.

@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Dec 2, 2018
@johnleider johnleider merged commit 980142f into vuetifyjs:master Dec 9, 2018
@dsseng dsseng deleted the fix/#5774 branch December 10, 2018 14:36
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] V-select won't close after opening and then tabbing out
2 participants