Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Badge direction issue on rtl mode #5684

Closed
miladmeidanshahi opened this issue Nov 21, 2018 · 0 comments · Fixed by #5801
Closed

[Bug Report] Badge direction issue on rtl mode #5684

miladmeidanshahi opened this issue Nov 21, 2018 · 0 comments · Fixed by #5801
Labels
good first issue A quick-win fix that would be great for new contributors S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@miladmeidanshahi
Copy link
Contributor

Versions and Environment

Vuetify: 1.3.9
Vue: 2.5.17
Browsers: Chrome 70.0.3538.110
OS: Linux x86_64

Steps to reproduce

in RTL mode it should be like this

.v-badge--left .v-badge__badge {
left: -22px;
right: initial;
}

Expected Behavior

prop left must be fine in RTL mode

Actual Behavior

currently in RTL mode prop left doesn't work correctly

Reproduction Link

https://codepen.io/miladmeidanshahi/pen/OazKaq
@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected good first issue A quick-win fix that would be great for new contributors labels Nov 21, 2018
jacekkarczmarczyk added a commit that referenced this issue Dec 4, 2018
@jacekkarczmarczyk
fix(VBadge): rtl mode
c37cc7f 
fixes #5684
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Dec 4, 2018
Merged
8 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Dec 4, 2018
johnleider added a commit that referenced this issue Dec 9, 2018
@johnleider
Merge branch 'master' into fix/#5684-badge-rtl
940500c
johnleider pushed a commit that referenced this issue Dec 9, 2018
@jacekkarczmarczyk @johnleider
fix(VBadge): rtl mode (#5801)
7eadc37 
fixes #5684
@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue A quick-win fix that would be great for new contributors S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VBadge): rtl mode vuetifyjs/vuetify
2 participants
@miladmeidanshahi @jacekkarczmarczyk