Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VDataIterator): select is too tall in IE11 #5656

Merged
merged 1 commit into from Dec 9, 2018
Merged

fix(VDataIterator): select is too tall in IE11 #5656

merged 1 commit into from Dec 9, 2018

Conversation

06b
Copy link
Contributor

@06b 06b commented Nov 19, 2018

Motivation and Context

Fixes #5655

How Has This Been Tested?

visually

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel
Copy link

vercel bot commented Nov 19, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@06b 06b changed the title Fix IE11 issue where select is too tall in data-iterator fix(VData-Iterator): select is too tall in IE11 Nov 27, 2018
@johnleider johnleider changed the title fix(VData-Iterator): select is too tall in IE11 fix(VDataIterator): select is too tall in IE11 Dec 2, 2018
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Dec 2, 2018
@johnleider johnleider merged commit 68a9aec into vuetifyjs:master Dec 9, 2018
@06b 06b deleted the IE11-data-iterator-select-fix branch December 19, 2018 14:45
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnleider johnleider johnleider approved these changes

@nekosaur nekosaur Awaiting requested review from nekosaur

Assignees

@nekosaur nekosaur

Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] IE11 v-select in data iterator pagination is too tall
3 participants
@06b @johnleider @nekosaur