Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rtl support for toolbar title #5642

Merged
merged 5 commits into from Dec 9, 2018
Merged

fix: add rtl support for toolbar title #5642

merged 5 commits into from Dec 9, 2018

Conversation

nasermirzaei89
Copy link
Contributor

@nasermirzaei89 nasermirzaei89 commented Nov 17, 2018

Description

Fix margin for toolbar's title if it's not first child for RTL direction

How Has This Been Tested?

Visually

Markup

<template>
  <v-app>
    <v-content>
      <template>
         <v-toolbar>
            <v-toolbar-side-icon @click="$vuetify.rtl = !$vuetify.rtl"></v-toolbar-side-icon>
            <v-toolbar-title>RTL Site Title</v-toolbar-title>
          </v-toolbar>
      </template>
    </v-content>
  </v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@vercel
Copy link

vercel bot commented Nov 17, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@jacekkarczmarczyk jacekkarczmarczyk added this to the v1.3.x milestone Dec 1, 2018
@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Dec 1, 2018
@codecov
Copy link

codecov bot commented Dec 1, 2018

Codecov Report

Merging #5642 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5642      +/-   ##
==========================================
+ Coverage   89.05%   89.07%   +0.01%     
==========================================
  Files         262      262              
  Lines        5923     5923              
  Branches     1468     1468              
==========================================
+ Hits         5275     5276       +1     
+ Misses        532      531       -1     
  Partials      116      116
Impacted Files Coverage Δ
...fy/src/components/transitions/expand-transition.js 64% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eadc37...b96afc4. Read the comment docs.

@johnleider johnleider changed the title add rtl support for toolbar title fix: add rtl support for toolbar title Dec 2, 2018
@johnleider johnleider merged commit 993fa6d into vuetifyjs:master Dec 9, 2018
@nasermirzaei89 nasermirzaei89 deleted the patch-1 branch December 31, 2018 11:08
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants