Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTextField): css rules were applied to checkboxes in v-select menu #5595

Merged
merged 3 commits into from Dec 9, 2018

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Nov 13, 2018

Description

All selectors FOO .v-input__slot where changed to FOO > .v-input__control > .v-input__slot

Motivation and Context

fixes #5508

How Has This Been Tested?

visually

Markup:

<template>
  <v-app>
    <v-content>
      <v-container>
        <v-autocomplete :items="['foo', 'bar']" attach multiple></v-autocomplete>
        <v-autocomplete box :items="['foo', 'bar']" attach multiple></v-autocomplete>
        <v-autocomplete solo :items="['foo', 'bar']" attach multiple></v-autocomplete>
        <v-autocomplete outline :items="['foo', 'bar']" attach multiple></v-autocomplete>
        <v-autocomplete :items="['foo', 'bar']" multiple></v-autocomplete>
        <v-autocomplete box :items="['foo', 'bar']" multiple></v-autocomplete>
        <v-autocomplete solo :items="['foo', 'bar']" multiple></v-autocomplete>
        <v-autocomplete outline :items="['foo', 'bar']" multiple></v-autocomplete>
      </v-container>
    </v-content>
  </v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected S: work in progress labels Nov 13, 2018
@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #5595 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5595      +/-   ##
==========================================
+ Coverage   89.05%   89.07%   +0.01%     
==========================================
  Files         262      262              
  Lines        5923     5922       -1     
  Branches     1468     1467       -1     
==========================================
  Hits         5275     5275              
+ Misses        532      531       -1     
  Partials      116      116
Impacted Files Coverage Δ
...ages/vuetify/src/components/VWindow/VWindowItem.ts 100% <0%> (ø) ⬆️
...fy/src/components/transitions/expand-transition.js 64% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eadc37...164b89a. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #5595 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5595      +/-   ##
==========================================
+ Coverage   89.05%   89.07%   +0.01%     
==========================================
  Files         262      262              
  Lines        5923     5923              
  Branches     1468     1468              
==========================================
+ Hits         5275     5276       +1     
+ Misses        532      531       -1     
  Partials      116      116
Impacted Files Coverage Δ
...fy/src/components/transitions/expand-transition.js 64% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eadc37...164b89a. Read the comment docs.

@johnleider johnleider merged commit 37c46b6 into master Dec 9, 2018
@johnleider johnleider deleted the fix/#5508-checkbox-style-in-v-select-list branch December 9, 2018 21:17
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Using box, multiple, and attach together on a select field adds incorrect CSS to checkboxes
2 participants