Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-timeline CSS bug with slot="opposite" and v-card #5397

Closed
jvanst opened this issue Oct 23, 2018 · 1 comment
Closed

v-timeline CSS bug with slot="opposite" and v-card #5397

jvanst opened this issue Oct 23, 2018 · 1 comment
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Milestone

Comments

@jvanst
Copy link
Contributor

jvanst commented Oct 23, 2018

Versions and Environment

Vuetify: v1.3.1
Vue: v2.5.17
Browsers: Chrome
OS: macOS Mojave

Steps to reproduce

When using a v-card component in the opposite slot the small arrow pointer is facing the wrong direction.

Expected Behavior

Expected it to point into the middle of the timeline.

Actual Behavior

Pointed outwards.

Reproduction Link

https://codepen.io/jvanst/pen/zmJgao

Additional Comments:

Here is a solution, should I create a PR?

.v-timeline-item
  display: flex
  flex-direction: row-reverse
  padding-bottom: 24px

  &:nth-child(odd):not(.v-timeline-item--right), &--left
    flex-direction: row

    .v-card:before, .v-card:after
      transform: rotate(180deg)
      left: 100%

    .v-timeline-item__opposite
      margin-left: 96px
      text-align: left

      .v-card:before, .v-card:after
        transform: rotate(0)
        left: (0% - 4px)

  &:nth-child(even):not(.v-timeline-item--left), &--right
    .v-card:before, .v-card:after
      right: 100%

    .v-timeline-item__opposite
      margin-right: 96px
      text-align: right

      .v-card:before, .v-card:after
        transform: rotate(180deg)
        right: (0% - 4px)
@nekosaur
Copy link
Member

PRs are always welcome

@johnleider johnleider added the S: has PR The issue has a pending Pull Request label Oct 23, 2018
@KaelWD KaelWD added this to the v1.3.x milestone Oct 25, 2018
@KaelWD KaelWD added the T: bug Functionality that does not work as intended/expected label Oct 25, 2018
nekosaur pushed a commit that referenced this issue Oct 26, 2018
This fixes a css bug when using v-card in the opposite slot.
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

4 participants