Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] v-btn-toggle looses last selected item when switching components #5384

Closed
fontzter opened this issue Oct 22, 2018 · 2 comments
Closed

[Bug Report] v-btn-toggle looses last selected item when switching components #5384

fontzter opened this issue Oct 22, 2018 · 2 comments
Assignees
@johnleider
Labels
T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Milestone
v1.3.x

Comments

@fontzter
Copy link
Contributor

fontzter commented Oct 22, 2018 •
edited

Versions and Environment

Vuetify: 1.3.1
Last working version: 1.2.10
Vue: 2.5.17
Browsers: Chrome 69.0.3497.95
OS: Chromium OS 10895.56.0

Steps to reproduce

create a component with a toggle button
bind the v-model to a Vuex store
leave the component and note that the last selected toggle is dropped

Expected Behavior

selected values should not change

Actual Behavior

the last selected value is removed

Reproduction Link

https://codepen.io/fontzter/pen/NOBqNb/
https://codepen.io/anon/pen/xyaKZz

Other comments

seems to be related to the new group items and the unregistering of each button.
@fontzter
Copy link
Contributor Author

much cleaner demo (thanks @jacekkarczmarczyk ) here: https://codepen.io/anon/pen/xyaKZz?editors=1010

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke labels Oct 22, 2018
@fontzter
Copy link
Contributor Author

a bit hacky workaround: https://codepen.io/fontzter/pen/ePQWZz?editors=1010

@johnleider johnleider self-assigned this Oct 25, 2018
@johnleider johnleider added this to the v1.3.x milestone Oct 25, 2018
nekosaur pushed a commit that referenced this issue Oct 26, 2018
@johnleider @nekosaur
fix(v-item-group): avoid unregistration process when destroyed
8217ea0 
if `v-item-group` was conditionally rendered, its children would alter the value when unregistering

fixes #5384
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnleider johnleider

Labels
T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Milestone
v1.3.x
Development

No branches or pull requests
3 participants
@fontzter @johnleider @jacekkarczmarczyk