Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/v-treeview #5373

Merged
merged 3 commits into from Oct 23, 2018
Merged

fix/v-treeview #5373

merged 3 commits into from Oct 23, 2018

Conversation

nekosaur
Copy link
Member

@nekosaur nekosaur commented Oct 21, 2018

Description

Fixed state sync issues

Motivation and Context

Fixes #5343
Fixes #5380

How Has This Been Tested?

playground, tests

Markup:

<template>
  <v-app>
    <v-treeview
      :items="items"
      :active.sync="selectedItems"
      :open.sync="openedItems"
      activatable
      selectable
      multiple-active
      transition
      item-key="name"
      item-text="name"
      active-class="primary"
    ></v-treeview>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      items: [
        { name: 'one', children: [{name: 'zxc', children: [{name: 'qwe'}, {name: '123'}]}, {name: '234'}] },
        { name: 'two' },
        { name: 'three' },
        { name: 'four' },
        { name: 'five' },
        { name: 'six' },
        { name: 'seven' },
        { name: 'eight' },
        { name: 'nine' },
        { name: 'ten' }
      ],
      selectedItems: [],
      openedItems: []
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

@codecov
Copy link

codecov bot commented Oct 21, 2018

Codecov Report

Merging #5373 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5373      +/-   ##
==========================================
+ Coverage   89.72%   89.81%   +0.08%     
==========================================
  Files         246      246              
  Lines        5830     5910      +80     
  Branches     1454     1491      +37     
==========================================
+ Hits         5231     5308      +77     
- Misses        476      478       +2     
- Partials      123      124       +1
Impacted Files Coverage Δ
src/components/VTreeview/VTreeview.ts 99.35% <100%> (-0.65%) ⬇️
src/components/VTabs/VTab.js 95.45% <0%> (-0.85%) ⬇️
src/components/VImg/VImg.ts 97.67% <0%> (-0.77%) ⬇️
src/components/VItemGroup/VItemGroup.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2e06d...64fe58d. Read the comment docs.

@nekosaur nekosaur changed the title fix/v treeview fix/v-treeview Oct 21, 2018
This was referenced Oct 21, 2018
@johnleider johnleider merged commit 0a9a3b0 into master Oct 23, 2018
@johnleider johnleider deleted the fix/v-treeview branch October 23, 2018 14:00
nekosaur added a commit that referenced this pull request Oct 26, 2018
* fix: make sure stuff is reactive

* fix: removed console logs and adjusted margins

* test: fixed broken tests
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset Treeview VTreeView active items are not synced
2 participants