Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab icon color not updating on theme change #5349

Closed
Guizzu opened this issue Oct 18, 2018 · 1 comment
Closed

Tab icon color not updating on theme change #5349

Guizzu opened this issue Oct 18, 2018 · 1 comment
Assignees
@KaelWD
Labels
T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke

Comments

@Guizzu
Copy link

Guizzu commented Oct 18, 2018 •
edited

Versions and Environment

Vuetify: 1.3.0
Vue: 2.5.17
Browsers: Chrome 69
OS: Windows 10

Previously worked in:

Vuetify: 1.2.7
Vue: 2.5.17

Steps to reproduce

Create a v-app with dark theme and a v-tabs component.

Expected Behavior

The v-tabs icon should be white if the dark theme is applied.

Actual Behavior

The v-tabs icon stays black.

Reproduction Link

https://codepen.io/Guizzoni/pen/VEXBoq
@KaelWD
Copy link
Member

KaelWD commented Oct 18, 2018

🙄

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke labels Oct 18, 2018
@KaelWD KaelWD self-assigned this Oct 18, 2018
nekosaur pushed a commit that referenced this issue Oct 21, 2018
@KaelWD @nekosaur
fix(VTab): remove theme override
bd8e220 
fixes #5349
@lock lock bot locked as resolved and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KaelWD KaelWD

Labels
T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Guizzu @KaelWD