fix data table sort icon not working when using font awesome 5 #5342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaelWD
reviewed
Oct 18, 2018
| @@ -33,25 +33,25 @@ theme(v-datatable, "v-datatable") | |||
| cursor: pointer | |||
| outline: 0 | |||
|
|
|||
| i | |||
| i, svg | |||
There was a problem hiding this comment.
Suggested change
| i, svg | |
| .v-icon |
You also missed one on line 17
johnleider
approved these changes
Oct 24, 2018
nekosaur
pushed a commit
that referenced
this pull request
Oct 26, 2018
* fix data table sort icon not work when using font awesome 5 * change css selector from i, svg to .v-icon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix data table sort icon not working when using font awesome 5 as default icon font.
Fixes #3548
Types of changes
Checklist:
masterfor bug fixes,devfor new features and breaking changes).