Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Picker: Wrong hour selected in 24hr mode #5316

Closed
haggys22 opened this issue Oct 12, 2018 · 0 comments · Fixed by #5317
Closed

Time Picker: Wrong hour selected in 24hr mode #5316

haggys22 opened this issue Oct 12, 2018 · 0 comments · Fixed by #5317
Assignees
@jacekkarczmarczyk
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@haggys22
Copy link
Contributor

Versions and Environment

Vuetify: v1.*

Previously worked in:

Vuetify: v0.17

Steps to reproduce

When selecting the hour, click on the left half of the 12 (maybe drag around a little bit between 12 and 23 to see which one is selected at which point)

Expected Behavior

Hour 12 is selected

Actual Behavior

Hour 23 is selected, you have to click on the right half for 12 to be selected

Reproduction Link

https://vuetifyjs.com/en/components/time-pickers#example-time24h-format
@haggys22 haggys22 mentioned this issue Oct 12, 2018
Merged
9 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Oct 12, 2018
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Oct 12, 2018
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Oct 17, 2018
nekosaur pushed a commit that referenced this issue Oct 26, 2018
@haggys22 @nekosaur
Fix #5316 (#5317)
84dc0d3 
* Fix #5316

In 24hr mode, when clicking on the left part of `12`, `23` was selected

* Add unit test for 13903ac4
@lock lock bot locked as resolved and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jacekkarczmarczyk jacekkarczmarczyk

Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5316
2 participants
@haggys22 @jacekkarczmarczyk