Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-iterable): rows-per-page selector not inheriting theme #5151

Merged
merged 1 commit into from Oct 2, 2018

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

Iterable's rows-per-page selector takes the theme from the app instead of the component (data-iterable, data-table)

https://codepen.io/anon/pen/pOBLaO

How Has This Been Tested?

visually

Markup:

<template>
  <v-app :dark="dark">
    <v-content>
      <v-container>
        <v-switch label="Dark" v-model="dark"></v-switch>
        <div class="headline mt-5">No theme</div>
        <v-data-table :headers="headers" :items="desserts">
          <template slot="items" slot-scope="props">
            <td><v-edit-dialog>Click<v-text-field slot="input"></v-text-field></v-edit-dialog></td>
            <td><v-edit-dialog large>Click<v-text-field slot="input"></v-text-field></v-edit-dialog></td>
          </template>
        </v-data-table>
        <div class="headline mt-5">Dark</div>
        <v-data-table dark :headers="headers" :items="desserts">
          <template slot="items" slot-scope="props">
            <td><v-edit-dialog>Click<v-text-field slot="input"></v-text-field></v-edit-dialog></td>
            <td><v-edit-dialog large>Click<v-text-field slot="input"></v-text-field></v-edit-dialog></td>
          </template>
        </v-data-table>
        <div class="headline mt-5">Light</div>
        <v-data-table light :headers="headers" :items="desserts">
          <template slot="items" slot-scope="props">
            <td><v-edit-dialog>Click<v-text-field slot="input"></v-text-field></v-edit-dialog></td>
            <td><v-edit-dialog large>Click<v-text-field slot="input"></v-text-field></v-edit-dialog></td>
          </template>
        </v-data-table>
      </v-container>
    </v-content>
  </v-app>
</template>

<script>
export default {
  data() {
    return {
      dark: false,
      headers: [
        { text: "Dessert (100g serving)", value: "name" },
        { text: "Iron (%)", value: "iron" }
      ],
      desserts: [{
        value: false,
        name: "Frozen Yogurt",
        iron: "1%"
      }]
    };
  }
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Sep 23, 2018
@jacekkarczmarczyk jacekkarczmarczyk changed the title fix(iterable): rows-per-page selector not inheriting theme fix(data-iterable): rows-per-page selector not inheriting theme Sep 23, 2018
@johnleider johnleider merged commit e580f79 into master Oct 2, 2018
@johnleider johnleider deleted the fix/data-iterable-rows-per-page-theme branch October 2, 2018 02:09
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants