fix(v-tabs): remove arbitrary delay on init

vuetifyjs · Oct 22, 2018 · 6810169 · 6810169
1 parent 2b2e06d
commit 6810169
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/components/VTabs/VTabs.js b/src/components/VTabs/VTabs.js
@@ -116,7 +116,7 @@ export default BaseItemGroup.extend({
         deprecate('@input', '@change', this)
       }
 
-      setTimeout(this.onResize, 33)
+      this.updateTabsView()
     },
     /**
      * When v-navigation-drawer changes the

diff --git a/test/unit/components/VTabs/VTabs.spec.js b/test/unit/components/VTabs/VTabs.spec.js
@@ -382,7 +382,7 @@ test('VTabs', ({ mount }) => {
 
   it('should set dimensions when onResize is called', async () => {
     const setWidths = jest.fn()
-    const wrapper = mount(VTabs, {
+    mount(VTabs, {
       propsData: {
         value: 'foo'
       },
@@ -396,22 +396,19 @@ test('VTabs', ({ mount }) => {
       },
       methods: { setWidths }
     })
+
     expect(setWidths).not.toBeCalled()
 
     await ssrBootable()
 
     expect(setWidths).toHaveBeenCalledTimes(1)
 
-    await new Promise(resolve => setTimeout(resolve, 33))
-
-    expect(setWidths).toHaveBeenCalledTimes(2)
-
     await resizeWindow(800)
 
-    expect(setWidths).toHaveBeenCalledTimes(3)
+    expect(setWidths).toHaveBeenCalledTimes(2)
 
     await resizeWindow(1800)
 
-    expect(setWidths).toHaveBeenCalledTimes(4)
+    expect(setWidths).toHaveBeenCalledTimes(3)
   })
 })