New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positives for system fonts in font-family-no-missing-generic-family-keyword #3794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@regseb Thanks for your contribution.
Is there somewhere in the specs we can find out more about these font values? I believe the current list is based on the one found in this spec.
Fascinating! Thanks for the sharing the link to the spec. I had no idea there were such things are system fonts and they are set using the Here's the relevant bit from the spec for those interested:
[Emphasis mine] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR LTGM. Nice work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @regseb 👍
Closes #3793
No, it's self explanatory.