Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autofix to selector-list-comma-newline-before #3517

Merged
merged 1 commit into from Aug 12, 2018
Merged

Add autofix to selector-list-comma-newline-before #3517

merged 1 commit into from Aug 12, 2018

Conversation

ota-meshi
Copy link
Member

Which issue, if any, is this issue related to?

selector-list-comma-newline-before in #2829

Is there anything in the PR that needs further explanation?

ex.

  • option: always***

    code:

    a,b {}

    fixed:

    a
,b {}

  • option: never-multi-line

    code:

    a
,b {\n}

    fixed:

    a,b {\n}

jeddy3
jeddy3 approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

hudochenkov
hudochenkov approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@hudochenkov hudochenkov merged commit 46df009 into stylelint:master Aug 12, 2018
@hudochenkov
Copy link
Member

  • Added: selector-list-comma-newline-before autofix (#3517).

@ota-meshi ota-meshi deleted the dev/fixable---selector-list-comma-newline-before branch August 12, 2018 08:42
This was referenced Aug 19, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ota-meshi @hudochenkov @jeddy3