Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundled support for styles in object literals #3506

Merged
merged 1 commit into from Aug 13, 2018
Merged

Conversation

gucong3000
Copy link
Member

Which issue, if any, is this issue related to?

#3264

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeddy3
Copy link
Member

jeddy3 commented Aug 3, 2018

@gucong3000 Can you post some examples of what kind of styles this parser supports, please? So that I can create an accurate CHANGELOG entry.

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, lint all the things!

Good work, @gucong3000!

Please, answer @jeddy3's question, so we can merge this PR.

@gucong3000
Copy link
Member Author

gucong3000 commented Aug 13, 2018

Can you post some examples of what kind of styles this parser supports, please? So that I can create an accurate CHANGELOG entry.

I'm sorry to be late, I didn't online because of my grandma's funeral.

  • style component factories

      import glamorous from 'glamorous'; // choose any name for the defaut export
    
      const Component = glamorous.div({ ... });
      const OtherComponent = glamorous('div')({ ... })
  • JSX inline style attributes

      <Div style={{ ... }}/>

@hudochenkov
Copy link
Member

@gucong3000 sorry to hear this. My condolences.

@jeddy3 jeddy3 merged commit 1917eb9 into master Aug 13, 2018
@jeddy3 jeddy3 deleted the postcss-jsx branch August 13, 2018 09:24
@jeddy3
Copy link
Member

jeddy3 commented Aug 13, 2018

  • Added: bundled support for styles in CSS-in-JS object literals (#3506).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants