Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to block-opening-brace-newline-after #3441

Merged
merged 9 commits into from Aug 13, 2018
Merged

Add autofix to block-opening-brace-newline-after #3441

merged 9 commits into from Aug 13, 2018

Conversation

ota-meshi
Copy link
Member

Which issue, if any, is this issue related to?

e.g. "Closes #000" or "None, as it's a documentation fix."

block-opening-brace-newline-after in #2829

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

ex.

  • option: always***

    code:

    a { color: pink; }

    fixed:

    a {
     color: pink; }
  • option: never-multi-line

    code:

    a {
    color: pink;
    background: orange; }

    fixed:

    a {color: pink;
    background: orange; }

In order to solve the problem of indentation due to newline insertion, the indentation processing was modified to be done at the last.

@jeddy3 jeddy3 changed the title Add autofix to block-opening-brace-newline-after Add autofix to block-opening-brace-newline-after Jul 21, 2018
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autofixing looks good.

I'm not sure what problem with indentation you're talking about. Anyway, it's better to do it in another PR. Could you remove indentation related changes from this PR and send them as another PR, please? Include before/after, so we could see what the problem is. Add tests for this problem.

@ota-meshi
Copy link
Member Author

@hudochenkov Thank you for checking!
I reverted the change of indentation. so please check again.

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeddy3 jeddy3 merged commit 287da28 into stylelint:master Aug 13, 2018
@jeddy3
Copy link
Member

jeddy3 commented Aug 13, 2018

  • Added: block-opening-brace-newline-after autofix (#3441).

@ota-meshi ota-meshi deleted the dev/fixable--block-opening-brace-newline-after branch August 13, 2018 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants