New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autofix to block-opening-brace-newline-after #3441
Add autofix to block-opening-brace-newline-after #3441
Conversation
* Fixed the behavior of `never-multi-line` when there are multiple comments. * Fixed to insert a newline at the after comment when comment exists. #3421 (comment)
block-opening-brace-newline-after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autofixing looks good.
I'm not sure what problem with indentation you're talking about. Anyway, it's better to do it in another PR. Could you remove indentation related changes from this PR and send them as another PR, please? Include before/after, so we could see what the problem is. Add tests for this problem.
@hudochenkov Thank you for checking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
e.g. "Closes #000" or "None, as it's a documentation fix."
block-opening-brace-newline-after
in #2829e.g. "No, it's self explanatory."
ex.
option:
always***
code:
fixed:
option:
never-multi-line
code:
fixed:
In order to solve the problem of
indentation
due to newline insertion, theindentation
processing was modified to be done at the last.