Change extensions ordering in webpack config #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbNickname
requested review from
alterx,
igor-dv and
tmeasday
as code owners
igor-dv
added
the
patch:yes
|
Thank you! |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Nov 6, 2018
Change extensions ordering in webpack config
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Support for mjs was added in #4466 but my project revealed some isses with graphql libraries that use mjs.
What I did
According to hint given in comment: graphql/graphql-js#1272 (comment) I changed ordering of extensions in webpack configuration. After applying this change my project setup was working fine again.
How to test
Try to tun storybook on project containing libraries that use .mjs extensions - in my case those were graphql related libraries
Is this testable with Jest or Chromatic screenshots?
Probably not
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
No
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]