Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Viewport - fix "defaultViewport" configuration #4683

Merged
merged 4 commits into from Nov 5, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Nov 1, 2018

Issue: #4007

What I did

  1. configureViewport was failing if "viewports" field was not defined
  2. defaultViewport was not persistent with navigation

P.S. Navigating between stories will always reset to the "defaultViewport" value, IMO it's a strange behavior when manually changing the viewport and navigating to a different story.

P.P.S the branch is called addon-jest/fix-configureviewport but I meant addon-vieport/fix-configureviewport

@igor-dv igor-dv self-assigned this Nov 1, 2018
@igor-dv igor-dv changed the title Addon Jest - fix "defaultViewport" configuration Addon Viewport - fix "defaultViewport" configuration Nov 1, 2018
@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #4683 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4683      +/-   ##
==========================================
- Coverage   35.59%   35.56%   -0.03%     
==========================================
  Files         557      557              
  Lines        6732     6731       -1     
  Branches      884      885       +1     
==========================================
- Hits         2396     2394       -2     
- Misses       3876     3877       +1     
  Partials      460      460
Impacted Files Coverage Δ
addons/viewport/src/manager/components/Panel.js 94.82% <66.66%> (-1.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729bc9c...a76ebb2. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hypnosphi Hypnosphi added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 5, 2018
@igor-dv igor-dv changed the base branch from master to next November 5, 2018 16:48
@igor-dv igor-dv merged commit 356fc90 into next Nov 5, 2018
@igor-dv igor-dv deleted the addon-jest/fix-configureviewport branch November 5, 2018 16:48
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 6, 2018
shilman pushed a commit that referenced this pull request Nov 6, 2018
…port

Addon Viewport - fix "defaultViewport" configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: viewport bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants